Incremental recompileMode - java.lang.NoClassDefFoundError: java/sql/ResultSetMetaData

[plavreshin]

Hi!

Thanks a lot for this plugin, I have enjoyed using it to build Java/Scala interop projects but I am observing few issues using it with default recompileMode incremental

To be more specific, build constantly fails both on the local machine and in CI environment for one rather large project with

2021-08-16 06:36:27.856 [inf] java.lang.NoClassDefFoundError: java/sql/ResultSetMetaData
2021-08-16 06:36:27.856 [inf] java.base/java.lang.Class.getDeclaredMethods0(Native Method)
2021-08-16 06:36:27.856 [inf] java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3166)
2021-08-16 06:36:27.856 [inf] java.base/java.lang.Class.privateGetPublicMethods(Class.java:3191)
2021-08-16 06:36:27.859 [inf] sbt.internal.inc.Incremental$.withClassfileManager(Incremental.scala:499)
2021-08-16 06:36:27.859 [inf] sbt.internal.inc.Incremental$.incrementalCompile(Incremental.scala:399)
2021-08-16 06:36:27.859 [inf] sbt.internal.inc.Incremental$.apply(Incremental.scala:166)
2021-08-16 06:36:27.859 [inf] sbt.internal.inc.IncrementalCompilerImpl.compileInternal(IncrementalCompilerImpl.scala:528)
2021-08-16 06:36:27.859 [inf] sbt.internal.inc.IncrementalCompilerImpl.$anonfun$compileIncrementally$1(IncrementalCompilerImpl.scala:482)
2021-08-16 06:36:27.859 [inf] sbt.internal.inc.IncrementalCompilerImpl.handleCompilationError(IncrementalCompilerImpl.scala:332)
2021-08-16 06:36:27.859 [inf] sbt.internal.inc.IncrementalCompilerImpl.compileIncrementally(IncrementalCompilerImpl.scala:420)
2021-08-16 06:36:27.859 [inf] sbt.internal.inc.IncrementalCompilerImpl.compile(IncrementalCompilerImpl.scala:137)
2021-08-16 06:36:27.859 [inf] sbt_inc.SbtIncrementalCompiler.compile(SbtIncrementalCompiler.java:179)
2021-08-16 06:36:27.859 [inf] scala_maven.ScalaCompilerSupport.incrementalCompile(ScalaCompilerSupport.java:361)
2021-08-16 06:36:27.859 [inf] scala_maven.ScalaCompilerSupport.compile(ScalaCompilerSupport.java:118)
2021-08-16 06:36:27.859 [inf] scala_maven.ScalaCompilerSupport.doExecute(ScalaCompilerSupport.java:88)
2021-08-16 06:36:27.859 [inf] scala_maven.ScalaMojoSupport.execute(ScalaMojoSupport.java:305)
2021-08-16 06:36:27.859 [inf] org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
2021-08-16 06:36:27.859 [inf] org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
2021-08-16 06:36:27.859 [inf] org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
2021-08-16 06:36:27.859 [inf] org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
2021-08-16 06:36:27.859 [inf] org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
2021-08-16 06:36:27.859 [inf] org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:190)
2021-08-16 06:36:27.859 [inf] org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:186)
2021-08-16 06:36:27.859 [inf] java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
2021-08-16 06:36:27.859 [inf] java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
2021-08-16 06:36:27.859 [inf] java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
2021-08-16 06:36:27.859 [inf] java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
2021-08-16 06:36:27.859 [inf] java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2021-08-16 06:36:27.859 [inf] java.base/java.lang.Thread.run(Thread.java:829)
2021-08-16 06:36:27.859 [inf]            

2021-08-16 06:36:44.060 [inf] [ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.5.3:compile (default) on project app-service-impl_2.13: Execution default of goal net.alchim31.maven:scala-maven-plugin:4.5.3:compile failed.: CompileFailed -> [Help 1]
2021-08-16 06:36:44.068 [inf] [ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:4.5.3:compile (default) on project app-db-impl_2.13: Execution default of goal net.alchim31.maven:scala-maven-plugin:4.5.3:compile failed: A required class was missing while executing net.alchim31.maven:scala-maven-plugin:4.5.3:compile: java/sql/ResultSetMetaData
2021-08-16 06:36:44.070 [inf] [ERROR] -----------------------------------------------------
2021-08-16 06:36:44.071 [inf] [ERROR] realm =    plugin>net.alchim31.maven:scala-maven-plugin:4.5.3
2021-08-16 06:36:44.073 [inf] [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
2021-08-16 06:36:44.077 [inf] [ERROR] urls[0] = file:/root/.m2/repository/net/alchim31/maven/scala-maven-plugin/4.5.3/scala-maven-plugin-4.5.3.jar
2021-08-16 06:36:44.080 [inf] [ERROR] urls[1] = file:/root/.m2/repository/org/apache/maven/maven-builder-support/3.3.9/maven-builder-support-3.3.9.jar
2021-08-16 06:36:44.083 [inf] [ERROR] urls[2] = file:/root/.m2/repository/com/google/guava/guava/18.0/guava-18.0.jar
2021-08-16 06:36:44.084 [inf] [ERROR] urls[3] = file:/root/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.21/plexus-interpolation-1.21.jar
2021-08-16 06:36:44.085 [inf] [ERROR] urls[4] = file:/root/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar
2021-08-16 06:36:44.086 [inf] [ERROR] urls[5] = file:/root/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.2/org.eclipse.sisu.inject-0.3.2.jar
2021-08-16 06:36:44.086 [inf] [ERROR] urls[6] = file:/root/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.6/plexus-component-annotations-1.6.jar
2021-08-16 06:36:44.087 [inf] [ERROR] urls[7] = file:/root/.m2/repository/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar
2021-08-16 06:36:44.088 [inf] [ERROR] urls[8] = file:/root/.m2/repository/org/eclipse/aether/aether-util/1.0.2.v20150114/aether-util-1.0.2.v20150114.jar
2021-08-16 06:36:44.088 [inf] [ERROR] urls[9] = file:/root/.m2/repository/com/google/inject/guice/4.0/guice-4.0-no_aop.jar
2021-08-16 06:36:44.088 [inf] [ERROR] urls[10] = file:/root/.m2/repository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar
2021-08-16 06:36:44.091 [inf] [ERROR] urls[11] = file:/root/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
2021-08-16 06:36:44.091 [inf] [ERROR] urls[12] = file:/root/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar

Following specs are used to compile and build project:

• JVM version

openjdk 11.0.11 2021-04-20
OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)

• Scala version - 2.13.6
• Scala-maven-plugin - 4.5.3
• Scalac flags:

  <arg>-deprecation</arg>
                        <arg>-encoding</arg>
                        <arg>UTF-8</arg>
                        <arg>-explaintypes</arg>
                        <arg>-feature</arg>
                        <arg>-language:existentials</arg>
                        <arg>-language:higherKinds</arg>
                        <arg>-language:implicitConversions</arg>
                        <arg>-unchecked</arg>
                        <arg>-Wdead-code</arg>
                        <arg>-Werror</arg>
                        <arg>-Wnumeric-widen</arg>
                        <arg>-Wunused:implicits</arg>
                        <arg>-Wunused:imports</arg>
                        <arg>-Wunused:linted</arg>
                        <arg>-Wunused:locals</arg>
                        <arg>-Wunused:params</arg>
                        <arg>-Wunused:patvars</arg>
                        <arg>-Wunused:privates</arg>
                        <arg>-Wvalue-discard</arg>
                        <arg>-Xcheckinit</arg>
                        <arg>-Xlint</arg>
                        <arg>-Xsource:3</arg>

• Compiler plugins:

  <compilerPlugins>
                        <compilerPlugin>
                            <groupId>org.typelevel</groupId>
                            <artifactId>kind-projector_2.13.6</artifactId>
                            <version>0.13.0</version>
                        </compilerPlugin>
                        <compilerPlugin>
                            <groupId>com.olegpy</groupId>
                            <artifactId>better-monadic-for_2.13</artifactId>
                            <version>0.3.1</version>
                        </compilerPlugin>
                    </compilerPlugins>
                    <jvmArgs>
                        <jvmArg>-Xss8m</jvmArg>
                        <jvmArg>-Xmx4096m</jvmArg>
                    </jvmArgs>

Switching back to recompileMode all would fix this issue I am seeing above but I would be very thankful if you could be so kind as to elaborate if there is any other workaround to address this issue.

Kind regards, Pavel

[davidB]

Thanks for reporting.
Sorry I'll not be able to take a look before several days.

Providing a minimal sample project that reproduce the issue will very useful to debug, to fix and to create a regression test.

[sky0hunter]

@davidB
Here's a minimal example when including slick and using the scala-maven-plugin 4.5.6:
https://github.com/sky0hunter/minimal-scala-maven-compiler-bug

Will only compile with recompileMode all, otherwise fails with missing java.sql.ResultSetMetaData

[slandelle]

That's most likely an issue wrt modules. I works as expected with Java 8.

[sky0hunter]

Yep, just encountered this bug because the JDK was upgraded to 17 ( but it fails with 11 too ), so as a workaround one can stick with Java 8 or set the recompileMode to all.

[LeUser111]

Running into the exact same problem here. A proper solution would be appreciated. We can't/don't want to go back to Java 8 because we're using the HttpClient from 11 and later...

@plavreshin Thank you very much for the work-around - it's helping us immensely :)

[slandelle]

It's a regression that was introduced in 4.5.0. Things used to work in 4.4.1.

[slandelle]

The culprit is this commit: b953d3d

In a sense, it's good news, because it means the issue is most likely on our side and not in zinc. cc @davidB

[slandelle]

30 changed files with 982 additions and 686 deletions

😭

[davidB]

@slandelle , Thanks for the fix.

Sorry for the big commit (in fact a squash-merge of several commit when I look at the comment), it was a big refactor.

[slandelle]

Hey @davidB
IMHO, if possible, it's better to have separate commits, eg one for moving from String to File/Path, one for merging the ScalaInstance creation strategies, etc. But I guess you lost track and didn't feel like starting over from scratch.
Nevermind, I was able to figure out the changes.

Cheers

[slandelle]

Please upgrade to 4.6.2