Change from usize to u64 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On [random-access-storage](https://github.com/datrs/random-access-storage) issue datrs/random-access-storage#6 has changed all types from `usize` into `u64` to be able to handle more than 4gbs on 32bits systems. > usize is 32 bits on a 32 bit system, so the storage would be limited to 4GB on such a system. When changing `random-access-storage` on `hypercore` (tracking: datrs/hypercore#100) one of the things I've noticed is that it wold be easier to also make `tree-index` use `u64` to integrate with `random-access-storage`. Very likely, this also means that we would need to bump to use more than 32Gb storages on `tree-index`. I've simply changed all declarations of usize into u64. All tests are passing. It also fixes Travis CI and update libraries to latest version. Needs: --- - [ ] datrs/flat-tree#44
6 tasks
yoshuawuyts
reviewed
Mar 2, 2020
Cargo.toml
Outdated
| [dependencies] | ||
| flat-tree = "3.4.0" | ||
| sparse-bitfield = "0.8.1" | ||
| flat-tree = { version = "4.1.0", git = "https://github.com/bltavares/flat-tree", branch = "usize-to-u64" } |
Contributor
There was a problem hiding this comment.
This needs to be updated before we merge. Thanks!
yoshuawuyts
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On random-access-storage
issue
datrs/random-access-storage#6 has changed all
types from
usizeintou64to be able to handle more than 4gbs on32bits systems.
When changing
random-access-storageonhypercore(tracking:datrs/hypercore#100) one of the things I've
noticed is that it wold be easier to also make
tree-indexuseu64to integrate withrandom-access-storage. Very likely, this alsomeans that we would need to bump to use more than 32Gb storages on
tree-index.I've simply changed all declarations of usize into u64. All tests are
passing.
It also fixes Travis CI and update libraries to latest version.
Needs:
Choose one: is this a 🐛 bug fix, a 🙋 feature, or a 🔦 documentation change?
Checklist
Context
Semver Changes