Implement async API for random-access-storage #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bltavares
force-pushed
the
async-trait
branch
from
8873a35 to
3b7e763
Compare
This was referenced Feb 27, 2020
Closed
|
Code is ready for review, but it needs #102 merged to land cleanly. I will keep it as Draft until the other PR lands, as it is built on top of it. |
|
I would propose to merge this an #102. We will want hypercore to be async, and definitely need it to integrate with hypercore-protocol. Keeping this unmerged makes it hard to continue working on hypercore as all PRs either have to based on this or current master as many signatures changed. We are still quite a way before a 1.0 and can refine later still if needed. |
This commit moves the API from a sync call into async functions using async_trait. We would like to use async operations on hypercore, and it would be nice to have the underlying storage using async-io when possible. As discussed on datrs#97, we could change the API to use async functions on the 'ram' trait. Async Trait methods are still unstable, but possible using the 'async-trait' crate through a macro. This PR moves the API to use async-fns. Tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async omplementation last commit / built on top of many other PRs
This commit moves the API from a sync call into async functions using async_trait.
We would like to use async operations on hypercore, and it would be nice to have the underlying storage using async-io when possible.
As discussed on #97, we could change the API to use async functions on the 'ram' trait.
Async Trait methods are still unstable, but possible using the 'async-trait' crate through a macro.
This PR moves the API to use async-fns. Tests are passing.
Choose one: a 🙋 feature
Checklist
Context
Semver Changes
minor as this is a breaking change but we are below1.0.0