JAVA-1932: Send DRIVER_NAME and DRIVER_VERSION in Startup #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olim7t
requested changes
Aug 27, 2018
| private static final String CQL_VERSION = "3.0.0"; | ||
|
|
||
| public final Map<String, String> options; | ||
| private final Map<String, String> options; |
Contributor
There was a problem hiding this comment.
We can keep a public final field here since the map is immutable.
The protocol classes are very simple and low-level, so they generally expose fields directly instead of getters.
| } | ||
| } else { | ||
| this.options = NullAllowingImmutableMap.of(CQL_VERSION_KEY, CQL_VERSION); | ||
| } |
| public <B> Message decode(B source, PrimitiveCodec<B> decoder) { | ||
| Map<String, String> map = decoder.readStringMap(source); | ||
| return new Startup(map.get(COMPRESSION_KEY)); | ||
| return new Startup(map); |
Contributor
There was a problem hiding this comment.
Yes, that's how it should have been in the first place.
olim7t
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Startupmessage so it can take a map of options as a constructor argument. The driver code will be changed to use this new constructor. The 2 existing constructors will remain and simply call the new constructor to the same end effect.