Skip to content
This repository was archived by the owner on Dec 8, 2023. It is now read-only.

Conversation

kabilar
Copy link
Collaborator

@kabilar kabilar commented Mar 8, 2023

  • Add Codespace devcontainers from workflow-calcium-imaging main branch
  • Add DataJoint config environment variables
  • Update requirements
  • Remove notebooks in anticipation of tutorial revamp
  • Remove jupytext synced scripts since GitHub now natively supports rich diffs with Jupyter notebooks.
  • Add demo notebooks
  • Update readme to mirror other repos. Include instructions for interactive tutorials with GitHub Codespaces.

@kabilar kabilar changed the title Add GitHub Codespace environment Add GitHub Codespace environment and demo notebooks Mar 9, 2023
@kabilar kabilar requested a review from kushalbakshi March 10, 2023 20:00
@kabilar kabilar marked this pull request as ready for review March 10, 2023 20:00
Copy link
Collaborator

@kushalbakshi kushalbakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kabilar, the codespace is working without any major issues. Just a couple of small suggestions. We should add example_data/ to .gitignore and remove the following line from demo_prepare.ipynb:

ephys.Curation().create1_from_clustering_task(clustering_key)

It throws an error since we're using ephys_no_curation. We're ready to merge after that.

@kabilar
Copy link
Collaborator Author

kabilar commented Mar 10, 2023

Hi @kabilar, the codespace is working without any major issues. Just a couple of small suggestions. We should add example_data/ to .gitignore and remove the following line from demo_prepare.ipynb:

ephys.Curation().create1_from_clustering_task(clustering_key)

It throws an error since we're using ephys_no_curation. We're ready to merge after that.

Thanks @kushalbakshi. On GitHub Codespace, I was defaulting to using the ephys_acute module (see default setting). Could it be that you are setting the ephys mode to ephys-no-curation in your dj_local_conf?

@kabilar
Copy link
Collaborator Author

kabilar commented Mar 10, 2023

Added an EPHYS_MODE environment variable to the Dockerfile to explicitly use the ephys_acute module.

@kushalbakshi
Copy link
Collaborator

Hi @kabilar, the codespace is working without any major issues. Just a couple of small suggestions. We should add example_data/ to .gitignore and remove the following line from demo_prepare.ipynb:

ephys.Curation().create1_from_clustering_task(clustering_key)

It throws an error since we're using ephys_no_curation. We're ready to merge after that.

Thanks @kushalbakshi. On GitHub Codespace, I was defaulting to using the ephys_acute module (see default setting). Could it be that you are setting the ephys mode to ephys-no-curation in your dj_local_conf?

I think there's definitely an issue on my end. Since it's working in your testing, I'm proceeding with the merge. Thank you!

@kushalbakshi kushalbakshi merged commit af0f6d4 into datajoint:main Mar 10, 2023
@kabilar
Copy link
Collaborator Author

kabilar commented Mar 10, 2023

Version 0.3.0 is tagged and released.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants