-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(ingestion): add feature flag for ingestion onboarding #15376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(ingestion): add feature flag for ingestion onboarding #15376
Conversation
|
✅ Meticulous spotted 0 visual differences across 998 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit bcccb8c. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 69 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
8424b48 to
01e7805
Compare
chriscollins3456
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have a suggestion on a different name but otherwise looks good! i think it makes sense to put version numbers in these flags in case we want another redesign around the same area in the future
| """ | ||
| Enables displaying the ingestion onboarding redesign | ||
| """ | ||
| showIngestionOnboardingRedesign: Boolean! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe let's just call it ingestionOnboardingRedesignV1
d13d642 to
5254a41
Compare
This PR adds a new feature flag:
showIngestionOnboardingRedesign