Skip to content

Conversation

@v-tarasevich-blitz-brain
Copy link
Contributor

This PR adds a new feature flag: showIngestionOnboardingRedesign

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Nov 21, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 21, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 21, 2025

✅ Meticulous spotted 0 visual differences across 998 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit bcccb8c. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Bundle Report

Changes will increase total bundle size by 69 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.7MB 69 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 69 bytes 19.08MB 0.0%

Files in assets/index-*.js:

  • ./src/appConfigContext.tsx → Total Size: 2.64kB

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a suggestion on a different name but otherwise looks good! i think it makes sense to put version numbers in these flags in case we want another redesign around the same area in the future

"""
Enables displaying the ingestion onboarding redesign
"""
showIngestionOnboardingRedesign: Boolean!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe let's just call it ingestionOnboardingRedesignV1

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Nov 24, 2025
@v-tarasevich-blitz-brain v-tarasevich-blitz-brain force-pushed the vt--cat-956--add-feature-flag-for-ingestion-onboarding branch from d13d642 to 5254a41 Compare November 24, 2025 16:00
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants