-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(searchBarV2): fix selecting option by hovering #15349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(searchBarV2): fix selecting option by hovering #15349
Conversation
|
✅ Meticulous spotted visual differences in 3 of 1015 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit 3d68320. This comment will update as new commits are pushed. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…tion-by-hover-oss
Bundle ReportChanges will increase total bundle size by 857 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
…tion-by-hover-oss
Port of the fix from SaaS - https://github.com/acryldata/datahub-fork/pull/7268
Linear - https://linear.app/acryl-data/issue/CAT-950/bug-unselecting-ask-datahub-option-leads-to-chat-page-instead-of
The Antd AutoComplete component select options by hovering on them but unselecting on mouse leave isn't added.
I've tried a few possible options like accessing to the select context and others way but they didn't work.
This fix is just overriding some div handlers to prevent selecting on hover and keep adding hovering styles. The fix added to our AutoComplete component behind prop toggler and disabled by default.