feat(ingest/sql-parsing): Add fallback parser for MSSQL stored procedures with control flow #15340
+1,423
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures with control flow Implements fallback parsing for MSSQL/TSQL stored procedures containing TRY/CATCH blocks and other control flow syntax that sqlglot doesn't support. The parser extracts and parses individual DML statements separately, then aggregates the lineage results.
github-actions
bot
added
the
ingestion
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
Use single TSQL_CONTROL_FLOW_KEYWORDS for both detection and filtering. Enables support for stored procedures with IF, WHILE, and other control flow.
treff7es
reviewed
Nov 19, 2025
| This is necessary because sqlglot doesn't support TSQL control flow syntax like | ||
| TRY/CATCH blocks, which causes the entire procedure to be unparseable. | ||
| """ | ||
| from datahub.sql_parsing.split_statements import split_statements |
Contributor
There was a problem hiding this comment.
Can we move import to the top?
| """ | ||
| from datahub.sql_parsing.split_statements import split_statements | ||
|
|
||
| logger.info( |
Contributor
There was a problem hiding this comment.
This should be on debug level
Contributor
There was a problem hiding this comment.
Am I right? I'm just thinking from user's perspective if it makes sense to show this on info level.
| return create | ||
|
|
||
|
|
||
| def _is_stored_procedure_with_unsupported_syntax( |
Contributor
There was a problem hiding this comment.
Can we match the dialect as well? This is an mssql specific syntax, right? Can we check for the dialect as well?
datahub-cyborg
bot
added
pending-submitter-response
… stored procedure parser - Add dialect check to ensure TSQL control flow detection only applies to MSSQL/TSQL - Fix infinite recursion bug by adding _disable_fallback_parser flag to prevent recursive fallback parser calls - Add test coverage for non-MSSQL dialects (PostgreSQL, MySQL) This addresses a code review comment and resolves a critical recursion issue where split_statements could return chunks still matching the CREATE PROCEDURE pattern, causing infinite loops.
datahub-cyborg
bot
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements fallback parsing for MSSQL/TSQL stored procedures containing TRY/CATCH blocks and other control flow syntax that sqlglot doesn't support. The parser extracts and parses individual DML statements separately, then aggregates the lineage results.