Skip to content

Improve Styling Consistency & Support for styled-components #15326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Improve Styling Consistency & Support for styled-components #15326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1491fb0
keep Documentation TabToolbar styling consistent with other tabs
Nov 18, 2025
b0b6de4
entityV2 StyledButton color configured by theme
Nov 18, 2025
14d3359
PillText fontWeight needs to be bold to meet accessibility acceptance…
Nov 18, 2025
af728a3
StyledTabsPrimary & StyledTabsSecondary color configured by theme
Nov 18, 2025
d367a4b
Editor ProseMirror text color configured by theme
Nov 18, 2025
38ebad3
add styles to Theme type for primary-color-darker & primary-color-lig…
Nov 18, 2025
ad030a3
entityV2 StyledButton hover color configured by theme
Nov 18, 2025
3bf962a
components/commonStyles colors configured by theme
Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datahub-web-react/src/alchemy-components/components/Editor/EditorTheme.tsx
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme provider to styled-component

Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ export const EditorContainer = styled.div<{ $readOnly?: boolean; $hideBorder?: b
line-height: 1.5;
white-space: pre-wrap;
margin: 0;
color: ${colors.gray[600]};
color: ${(props) => props.theme.styles['text-color']};

a {
font-weight: 500;
color: ${colors.primary[500]};
color: ${(props) => props.theme.styles['primary-color']};
}

li {
Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/src/alchemy-components/components/Pills/Pill.tsx
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessibility

Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export function Pill({
onClick={onPillClick}
style={{
backgroundColor: customStyle?.backgroundColor,
fontWeight: "bold",
}}
title={showLabel ? label : undefined}
className={className}
Expand Down
4 changes: 2 additions & 2 deletions datahub-web-react/src/alchemy-components/components/Tabs/Tabs.tsx
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme provider to styled-component

Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const StyledTabsPrimary = styled(AntTabs)<{
.ant-tabs-tab {
padding: 8px 0;
font-size: 14px;
color: ${colors.gray[600]};
color: ${(props) => props.theme.styles['primary-color']};
}

${({ $addPaddingLeft }) =>
Expand Down Expand Up @@ -116,7 +116,7 @@ const StyledTabsSecondary = styled(AntTabs)<{
padding: 8px 8px;
border-radius: 4px;
font-size: 14px;
color: ${colors.gray[600]};
color: ${(props) => props.theme.styles['primary-color']};
}

${({ $addPaddingLeft }) =>
Expand Down
6 changes: 3 additions & 3 deletions datahub-web-react/src/alchemy-components/components/commonStyles.ts
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme provider to styled-component

Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@ export const INPUT_MAX_HEIGHT = '40px';
export const formLabelTextStyles = {
fontWeight: typography.fontWeights.normal,
fontSize: typography.fontSizes.md,
color: colors.gray[600],
color: `${(props) => props.theme.styles['primary-color']}`,
};

export const inputValueTextStyles = (size = 'md') => ({
fontFamily: typography.fonts.body,
fontWeight: typography.fontWeights.normal,
fontSize: typography.fontSizes[size],
color: colors.gray[700],
color: `${(props) => props.theme.styles['primary-color-dark']}`,
});

export const inputPlaceholderTextStyles = {
fontFamily: typography.fonts.body,
fontWeight: typography.fontWeights.normal,
fontSize: typography.fontSizes.md,
color: colors.gray[400],
color: `${(props) => props.theme.styles['primary-color-light']}`,
};
5 changes: 3 additions & 2 deletions datahub-web-react/src/app/entityV2/domain/DataProductsTab/DataProductsTab.tsx
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use shared styled-component over out-of-the-box antd component

Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { useEntityContext, useEntityData } from '@app/entity/shared/EntityContex
import CreateDataProductModal from '@app/entityV2/domain/DataProductsTab/CreateDataProductModal';
import DataProductResult from '@app/entityV2/domain/DataProductsTab/DataProductResult';
import TabToolbar from '@app/entityV2/shared/components/styled/TabToolbar';
import StyledButton from '@app/entityV2/shared/components/styled/StyledButton';
import { ANTD_GRAY, REDESIGN_COLORS } from '@app/entityV2/shared/constants';
import { SearchBar } from '@app/search/SearchBar';
import { DOMAINS_FILTER_NAME } from '@app/search/utils/constants';
Expand Down Expand Up @@ -107,13 +108,13 @@ export default function DataProductsTab() {
return (
<>
<TabToolbar>
<Button
<StyledButton
type="text"
onClick={() => setIsCreateModalVisible(true)}
data-testid="create-data-product-button"
>
<PlusOutlined /> New Data Product
</Button>
</StyledButton>
<SearchBar
initialQuery={query || ''}
placeholderText="Search data products..."
Expand Down
6 changes: 6 additions & 0 deletions datahub-web-react/src/app/entityV2/shared/components/styled/StyledButton.tsx
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme provider to styled-component

Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,10 @@ export default styled(Button)`
line-height: 20px;
vertical-align: top;
border-radius: 5px;
color: ${(props) => props.theme.styles['primary-color']};

:hover {
color: ${(props) => props.theme.styles['primary-color-darker']};
background-color: transparent;
}
`;
4 changes: 0 additions & 4 deletions datahub-web-react/src/app/entityV2/shared/tabs/Documentation/DocumentationTab.tsx
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styling consistency

Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@ const DocumentationContainer = styled.div`
`;

const StyledTabToolbar = styled(TabToolbar)`
background-color: ${REDESIGN_COLORS.LIGHT_GREY};
border-top-left-radius: 4px;
border-bottom-left-radius: 4px;
border-left: 2px solid #5c3fd1;
padding: 8px 20px;
margin: 2px 14px 2px 12px;

Expand Down
2 changes: 2 additions & 0 deletions datahub-web-react/src/conf/theme/themeV1.ts
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expand theme styles

Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ const themeV1: Theme = {
styles: {
'primary-color': '#1890ff',
'primary-color-light': '#F0F5FF',
'primary-color-lighter': '#F0F5FF',
'primary-color-dark': '#002766',
'primary-color-darker': '#002766',
'layout-header-background': 'white',
'layout-header-color': '#434343',
'layout-body-background': 'white',
Expand Down
3 changes: 3 additions & 0 deletions datahub-web-react/src/conf/theme/themeV2.ts
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expand theme styles

Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ const themeV2: Theme = {
styles: {
'primary-color': '#533FD1',
'primary-color-dark': '#5C3FD1',
'primary-color-darker': '#5C3FD1',
'primary-color-light': '#ece9f8',
'primary-color-lighter': '#ece9f8',
'layout-header-background': 'white',
'layout-header-color': '#434343',
'body-background': 'white',
'border-color-base': '#ececec',
Expand Down
2 changes: 2 additions & 0 deletions datahub-web-react/src/conf/theme/types.ts
View file
Open in desktop
Copy link
Contributor Author

@liannab liannab Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expand theme styles

Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ export type Theme = {
styles: {
'primary-color': string;
'primary-color-light': string;
'primary-color-lighter': string;
'primary-color-dark': string;
'primary-color-darker': string;
'layout-header-color': string;
'body-background': string;
'border-color-base': string;
Expand Down
Loading