This repository was archived by the owner on May 17, 2024. It is now read-only.
Allow dbt selectors #511
Merged
Allow dbt selectors #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went ahead and handled the test changes, outside of that I mostly made some stylistic changes and handled a couple exception scenarios. Really appreciate the contribution @dave-connors-3 , I'm going to tag some team members to review, but I think this is in good shape! |
dlawin
added
enhancement
dlawin
reviewed
Apr 28, 2023
nolar
approved these changes
May 5, 2023
Co-authored-by: Sergey Vasilyev <[email protected]>
dlawin
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #444
Here's some early thinking on how we might support dbt selection syntax as an arg to data-diff!
In dbt 1.5+ there's a new interface to call out to dbt -- using a
dbt lscommand under the hood, we can take the argument passed to the new flag--selector-sand return the models that match that selector.This is absolutely going to fail some tests, so would love a little bit of guidance on which tests to update, and how they might need to change!