Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Conversation

sirupsen
Copy link
Contributor

Add Snowflake and Presto to CI with unittest-parallel, which required a bunch of changes:

  1. Remove the initial type tests in favour of only test_database_types.py, since Preql doesn't support e.g. Presto. This meant moving some timezone tests, but I think this simplifies things long-term!
  2. Ensure that all tests are safe to be run concurrently both with the same suite running in parallel, or other tests. Every test's tables now get unique names.
  3. Add secrets for Snowflake and Presto which can be set through the environment in Github actions.
  4. Tests aren't run for first-time collaborators by default. This is to prevent people from being able to fork, put up a PR, and leak our secrets. It's only for first-time collaborators it is required though, so for repeat collaborators, they won't have issues.

Redshift, BigQuery, and Oracle are still missing. They require some more configuration.

@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:13 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:13 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:13 Inactive
@sirupsen sirupsen changed the title tests: test snowflake in github actions tests: parallel + snowflake, presto in CI Jun 30, 2022
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:26 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:26 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:26 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:26 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:30 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:30 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:30 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:30 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:30 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:30 Inactive
@sirupsen sirupsen deployed to AUTHENTICATION June 30, 2022 15:30 Active
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:30 Inactive
@sirupsen sirupsen force-pushed the test-snowflake-prod branch from f1e2411 to 5665f8e Compare June 30, 2022 15:31
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:31 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:31 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:31 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:31 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:31 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:31 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:31 Inactive
@sirupsen sirupsen temporarily deployed to AUTHENTICATION June 30, 2022 15:31 Inactive
@sirupsen sirupsen changed the title tests: parallel + snowflake, presto in CI tests: parallel + snowflake, presto in CI + benchmark scripts Jun 30, 2022
@sirupsen sirupsen force-pushed the test-snowflake-prod branch from 61380f6 to d06d2ff Compare June 30, 2022 20:49
@erezsh erezsh force-pushed the test-snowflake-prod branch from d06d2ff to 43c4042 Compare July 1, 2022 08:32
Copy link
Contributor

@erezsh erezsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erezsh erezsh merged commit 5c3eba4 into master Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants