refactor(diff): extract secret handling to preHandleSecrets #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yxxhero <[email protected]>
|
see: #785 |
|
@lucasfcnunes is this ok for you? I added tests for your case. |
lucasfcnunes
suggested changes
May 25, 2025
Co-authored-by: Lucas Fernando Cardoso Nunes <[email protected]>
Signed-off-by: yxxhero <[email protected]>
|
@lucasfcnunes all done! |
|
@lucasfcnunes thanks for your reviewing. it's good comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the handling of secrets in the
diffpackage to improve code reuse and readability. The changes include introducing a helper function for decoding secrets, updating related methods to use this helper, and adding a new test case to ensure correct behavior when bothstringDataanddatafields are present in Kubernetes secrets.Refactoring for code reuse and clarity:
preHandleSecretsindiff/diff.goto centralize the logic for decoding secrets and handling errors. This function is now used in bothredactSecretsanddecodeSecretsto avoid code duplication. [1] [2] [3]Testing improvements:
diff_test.goto verify thatdecodeSecretscorrectly prioritizesstringDataoverdatawhen both fields are present in Kubernetes secrets. This ensures the expected behavior when handling secret resources.