Add enable dns flag #544
Merged
Add enable dns flag #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
LGTM. Thanks for raising the issue and submitting this PR!
Re; tests, I think that's not strictly required for this case right now. All we have to do here is, pass enable-dns as-is from helm-diff to downstream helm-template.
We could later extract the part of the template function that composes flags, args, cmd and write some unit test for that extracted function, though!
If you could submit follow-up PR(s) to do so, that would be awesome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #447
This adds the
--enable-dnsoption to the upgrade command. And enables DNS Lookup during rendering the templates.I didn't add any tests, because there are also no test for the other options. If tests are required, can you give my hints where to start.