Short diff output (#29 with updates) #53
Conversation
By default disabled, can be enabled and configured with `--context NUM`.
mumoshu
left a comment
mumoshu
left a comment
There was a problem hiding this comment.
@zytek @njam Thank you so much for this! The implementation LGTM.
Although this seems nice to have in helm-diff, it is the most complex logic in the code-base. That makes me wanting to add CI :)
So, would you mind adding a single test-case to printDiff for the case context is bigger than zero? So that I can setup CI to run it.
Please tell me if you don't have bandwidth to do so :)
|
|
||
| revisionCmd.Flags().BoolP("suppress-secrets", "q", false, "suppress secrets in the output") | ||
| revisionCmd.Flags().StringArrayVar(&diff.suppressedKinds, "suppress", []string{}, "allows suppression of the values listed in the diff output") | ||
| revisionCmd.Flags().IntVarP(&diff.outputContext, "context", "C", -1, "output NUM lines of context around changes") |
There was a problem hiding this comment.
For anyone interested - this corresponds to the equivalent option in the diff command:
$ diff --help | grep -- -C
-c -C NUM --context[=NUM] Output NUM (default 3) lines of copied context.
I will gladly do it, to learn how it's done! I can do it on the next weekend. If somebody else wants to do it beforehand, feel free. UPDATE: It's done in #29 |
3 participants
Just took #29 and updated it to work with master.