Remove support for helm2 #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
approved these changes
May 16, 2023
Collaborator
mumoshu
left a comment
mumoshu
left a comment
There was a problem hiding this comment.
LGTM. Super excited to finally drop the v2 support! It has been a long journey!
hexcsl
pushed a commit
to hexcsl/helm-diff
that referenced
this pull request
Jul 3, 2023
* Remove support for helm2 * fixup! Merge branch 'master' into remove-helm2-support --------- Co-authored-by: Yusuke Kuoka <[email protected]>
hexcsl
pushed a commit
to hexcsl/helm-diff
that referenced
this pull request
Jul 3, 2023
* Remove support for helm2 * fixup! Merge branch 'master' into remove-helm2-support --------- Co-authored-by: Yusuke Kuoka <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to remove support for helm2 from helm diff as its EOL for years now.
I'm leaving this as PR for a while to collect some feedback if anybody is still using helm 2.