Skip to content

Conversation

@unacceptable
Copy link
Contributor

This is my first Go project submission. Please tell me what I need to improve.

@unacceptable
Copy link
Contributor Author

#350

@unacceptable
Copy link
Contributor Author

unacceptable commented Jan 13, 2022

I have linted install-binary.sh. I have no clue how to fix the Cygwin issue.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @unacceptable ☺️

@mumoshu mumoshu merged commit 5f58fc8 into databus23:master Jan 22, 2022
@mumoshu mumoshu mentioned this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants