Skip to content

Conversation

@jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jan 9, 2022

Hi,

i recently read

It would be great if anyone could enahnce our CI workflow to cover cygwin (if it's possible).

and thought I can re-design the CI workflow in general in form as a proposal.

The new CI based on Github Action. It covers all tasks from Circle CI +

To gain a preview of the flow, take a look here: https://github.com/jkroepke/helm-diff/actions/runs/1673641310

Most parts of the CI workflow are copied from https://github.com/jkroepke/helm-secrets

As mention in the tests, the installation on cygwin is broken.

@mumoshu
Copy link
Collaborator

mumoshu commented Jan 9, 2022

cc/ @databus23 Are you happy with enabling/using GitHub Actions on this repo? (I am 😃 But I wanted to confirm

@databus23
Copy link
Owner

Sure. Lets do it.

Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke
Copy link
Contributor Author

jkroepke commented Jan 10, 2022

To initially setup github action

  • this needs to be merged first
    OR
  • the PR author needs to be a collaborator.
    OR
  • In worst, the PR author needs to be a collaborator and this branch needs to be a local branch.

I would suggest @databus23 or @mumoshu create a branch (not a fork), merge my branch into it and create a new pull request.

I guess, Github does not allow external contributers to create new workflows.

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm merging this anyway. Let's address any issues(if any) after the first run of this on our master branch.
Thanks a lot for your contribution @jkroepke!

@mumoshu mumoshu merged commit b04e040 into databus23:master Jan 10, 2022
@jkroepke jkroepke deleted the gh-actions branch January 16, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants