Skip to content

Fix regression on plugin installation for Helm 2 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Fix regression on plugin installation for Helm 2 #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions install-binary.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ export GREP_COLOR="never"

HELM_MAJOR_VERSION=$(helm version --client --short | awk -F '.' '{print $1}')

if [ "$HELM_MAJOR_VERSION" = "Client: v2" ]; then
: ${HELM_PLUGIN_DIR:="$(helm home --debug=false)/plugins/helm-diff"}
fi
: ${HELM_PLUGIN_DIR:="$(helm home --debug=false)/plugins/helm-diff"}

# Convert the HELM_PLUGIN_DIR to unix if cygpath is
# available. This is the case when using MSYS2 or Cygwin
Expand Down