switch to go modules #194
Merged
switch to go modules #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@databus23 FYI |
|
@databus23 Friendly ping :) |
|
Requesting your review @databus23 |
|
Maybe @mumoshu can help here as well? :) |
mumoshu
reviewed
Jul 20, 2020
| # Clear the "unreleased" string in BuildMetadata | ||
| LDFLAGS += -X $(PKG)/vendor/k8s.io/helm/pkg/version.BuildMetadata= | ||
| LDFLAGS += -X $(PKG)/vendor/k8s.io/helm/pkg/version.Version=$(shell grep -A1 "package: k8s.io/helm" glide.yaml | sed -n -e 's/[ ]*version:.*\(v[.0-9]*\).*/\1/p') | ||
| LDFLAGS += -X $(PKG)/vendor/k8s.io/helm/pkg/version.Version=$(shell grep -A1 "package: k8s.io/helm" go.mod | sed -n -e 's/[ ]*version:.*\(v[.0-9]*\).*/\1/p') |
There was a problem hiding this comment.
I think this should now grep for k8s.io/helm v2.11.0+incompatible in go.mod and the sed expr should be rewritten to extract v2.11.0 only. But let's defer it to another issue/pr as I've left this not reviewed too long!
mumoshu
approved these changes
Jul 20, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.