Increase the size of bufio.Scanner.Buffer to 10MiB. #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the 1MB size limit here was taking into account the 1MB size limit of resources by etcd, but K8S allows us to define multiple resources in one YAML file. So it is reasonable to increase or remove this limit. |
databus23
approved these changes
Feb 24, 2020
Owner
|
Thanks! |
Contributor
Author
|
Thank you for the prompt response! It would be nice if we can get a patch version released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #182
We are experiencing this issue while updating the dashboard JSON contents of Grafana chart, which leads to a huge length of the YAML specs.