-
Notifications
You must be signed in to change notification settings - Fork 311
Improve code quality using gofmt and go lint #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@databus23, @mumoshu. Can this be reviewed and merged? |
0dbaf7e to
e213259
Compare
|
self-reviewed and pushed the changes. |
mumoshu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aananthraj Hey! Thanks a lot for your contribution.
This looks great overall!
Only change I'd like to see is to retain the name of DiffManifests so that the method name conforms to the convention of being "verb (+ noun)". I believe Diff was used like a a verb after the *unix diff command.
I do agree with your point. I had to change it, as it was reported by |
|
@aananthraj Ah good point. Then just It is a breaking change for anyone using helm-diff as a go library. But it isn't an intended use-case at the moment and I'll keep it until I hear from anyone requesting to bring back the go-level API compatibility. That said, please forgive me if I reverted part of this or altered the lint script to ignore errors on the two method names :) |
Sure will make those changes and update here
https://godoc.org/github.com/databus23/helm-diff
No issues on this 👍 |
This Commit, - Refactors code using `gofmt` and `go lint` to improve code quality. - Adds scripts to `gofmt` code and to update required changes - Adds scripts to `go lint` and `go vet` code - Adds `lint` stage before `build` to retain code quality - Adds Godocs Badge to README.md
e213259 to
74ce777
Compare
|
@mumoshu made those requested changes |
mumoshu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for your efforts!
|
Thanks @mumoshu for the prompt responce and support 👍 |
This PR,
gofmtandgo lintto improve code quality.gofmtcode and to update required changesgo lintandgo vetcodelintstage beforebuildto retain code qualitypreview:
to 
goes from