Support --reuse-values #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
databus23
approved these changes
Nov 13, 2017
Owner
databus23
left a comment
databus23
left a comment
There was a problem hiding this comment.
Thanks for the PR. One minor nit.
main.go
Outdated
| f.BoolP("version", "v", false, "show version") | ||
| f.VarP(&diff.valueFiles, "values", "f", "specify values in a YAML file (can specify multiple)") | ||
| f.StringArrayVar(&diff.values, "set", []string{}, "set values on the command line (can specify multiple or separate values with commas: key1=val1,key2=val2)") | ||
| f.BoolVar(&diff.reuseValues, "reuse-values", false, "when upgrading, reuse the last release's values, and merge in any new values. If '--reset-values' is specified, this is ignored.") |
Owner
There was a problem hiding this comment.
I think the second sentence was copy&pasted from helm and is a little misleading as helm-diff does not have a --reset-values flag.
Contributor
Author
There was a problem hiding this comment.
You're totally right 😄 , will fix
Contributor
Author
There was a problem hiding this comment.
Updated; I just shortened the description to remove the irrelevant bits.
player-two
force-pushed
the
reuse-values
branch
from
e488713 to
500a1ae
Compare
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Love the plugin - it's been incredibly helpful for making upgrades smooth. I think it would be very convenient to be able to replace
diffwithupgradefrom a previous shell command and rerun it. That is one less way for me to make mistakes during the process. I'd imagine you don't want to start a trend of copying all the options forhelm upgradeinto this plugin. This one seems pretty crucial to me, but let me know what you think!FWIW, I was not able to test this on Helm 2.7. I'm currently running 2.6, so I checked out
v2.5.0+1(HEAD~1at time of writing) and branched off that to build and test. I thencherry-picked that commit into this branch. So all that said it'd be great if you can either a) test this on 2.7 yourself or b) give me a few weeks to upgrade my Tiller. I share it with a handful of people so I can't do it immediately, but this change seems simple enough I expect it to work.