Skip yaml blocks without any metadata #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@databus23 @mumoshu would love to get this merged in if you don't have any objections. While I think the error is harmless, it would be nice to get rid of the confusing output. If you want any changes before accepting, let me know. |
mumoshu
approved these changes
Mar 19, 2019
Collaborator
mumoshu
left a comment
mumoshu
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for your patience, and contribution!
|
Hey @mumoshu, first of all I want to say thanks for this super helpful helm plugin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the variant of #48 reported by bfin, jcalahan and adidenko.
If you have templates that wind up containing only comments, they should be skipped. This change checks to see if the metadata is completely empty to detect effectively blank yaml content.
To do this without an extraneous comparison variable, I had to unshadow the metadata type. This resulted in a few extra cosmetic changes in the diff.