helm plugin install does not pin versions

[clux]

Hey,

I did a rebuild of an image today with pinned helm and helm diff plugin using:

helm plugin install https://github.com/databus23/helm-diff --version v2.8.2+2

and ended up getting a version of helm diff that now required an upgrade subcommand. Is this way of version pinning not meant to work, or is the semver tag actually considered floating?

[databus23]

Hmm that should work. 2.8.2+2 doesn't have the cli refactoring in. what does helm diff -v say (or helm diff version if that doesn't work)

Looks like you got v2.9.0+1

[clux]

Yep, I totally got v2.9.0+1 (only last command worked).

CI logs:

+ helm plugin install https://github.com/databus23/helm-diff --version v2.8.2+2
*   Trying 192.30.253.116...
* TCP_NODELAY set
* Connected to api.github.com (192.30.253.116) port 443 (#0)
* ALPN, offering http/1.1
* successfully set certificate verify locations:
  CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs/
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
* TLSv1.2 (IN), TLS handshake, Server hello (2):
{ [108 bytes data]
* TLSv1.2 (IN), TLS handshake, Certificate (11):
{ [3091 bytes data]
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
{ [333 bytes data]
* TLSv1.2 (IN), TLS handshake, Server finished (14):
{ [4 bytes data]
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
} [70 bytes data]
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
} [1 bytes data]
* TLSv1.2 (OUT), TLS handshake, Finished (20):
} [16 bytes data]
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
{ [1 bytes data]
* TLSv1.2 (IN), TLS handshake, Finished (20):
{ [16 bytes data]
* SSL connection using TLSv1.2 / ECDHE-RSA-AES128-GCM-SHA256
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: C=US; ST=California; L=San Francisco; O=GitHub, Inc.; CN=*.github.202132.xyz
*  start date: Jan 18 00:00:00 2017 GMT
*  expire date: Apr 17 12:00:00 2020 GMT
*  subjectAltName: host "api.github.com" matched cert's "*.github.202132.xyz"
*  issuer: C=US; O=DigiCert Inc; OU=www.digicert.com; CN=DigiCert SHA2 High Assurance Server CA
*  SSL certificate verify ok.
> GET /repos/databus23/helm-diff/releases/latest HTTP/1.1
> Host: api.github.com
> User-Agent: curl/7.59.0
> Accept: */*
> 
< HTTP/1.1 200 OK
< Server: github.com
< Date: Fri, 27 Apr 2018 15:48:55 GMT
< Content-Type: application/json; charset=utf-8
< Content-Length: 6919
< Status: 200 OK
< X-RateLimit-Limit: 60
< X-RateLimit-Remaining: 55
< X-RateLimit-Reset: 1524847551
< Cache-Control: public, max-age=60, s-maxage=60
< Vary: Accept
< ETag: "580ff2ce7b106a62239f9dde64574d11"
< Last-Modified: Thu, 26 Apr 2018 23:07:35 GMT
< X-GitHub-Media-Type: github.v3; format=json
< Access-Control-Expose-Headers: ETag, Link, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval
< Access-Control-Allow-Origin: *
< Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
< X-Frame-Options: deny
< X-Content-Type-Options: nosniff
< X-XSS-Protection: 1; mode=block
< Referrer-Policy: origin-when-cross-origin, strict-origin-when-cross-origin
< Content-Security-Policy: default-src 'none'
< X-Runtime-rack: 0.034606
< X-GitHub-Request-Id: E796:2B62:1ED460D:43F0FD0:5AE34667
< 
{ [346 bytes data]
* Connection #0 to host api.github.com left intact
Downloading https://github.com/databus23/helm-diff/releases/download/v2.9.0%2B1/helm-diff-linux.tgz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   609    0   609    0     0   1503      0 --:--:-- --:--:-- --:--:--  1500
100 4774k  100 4774k    0     0   806k      0  0:00:05  0:00:05 --:--:--  970k
Preparing to install into /config/.helm/plugins/helm-diff

[clux]

so, it works if you pin with --version v2.8.2, the + probably isn't valid semver and fails somewhere up the chain.

[databus23]

It doesn't work but I don't understand why.
The install script tries to infer the version number from the checkout revision: https://github.com/databus23/helm-diff/blob/master/install-binary.sh#L70

$HELM_HOME/.helm/cache/plugins/https-github.202132.xyz-databus23-helm-diff/ is checked out to v2.8.2+2 and running ./install-binaries.sh from there installs the correct version.

Not sure why it pulls the latest version when running helm plugin install

[clux]

still, pretty dumb that it just falls back to the latest version if it can't handle the version string.

[decoursin]

Yeah, so a workaround that worked for me is: clone helm-diff github repo into $HELM_HOME/.helm/plugins/helm-diff; cd $HELM_HOME/.helm/plugins/helm-diff; git checkout v2.8.2+2; ./install-binary.sh

[clux]

I fell back to the tarball install, which also is pinnable:

ENV HELMDIFFVER="2.8.2%2B2"
RUN curl -sSL https://github.com/databus23/helm-diff/releases/download/v${HELMDIFFVER}/helm-diff-linux.tgz | tar xvz -C $(helm home)/plugins

[osterman]

Our CI is constantly breaking on helm-diff despite version pinning. Usually clicking retry resolves it. Seems related to this issue.

Output:

Downloading 
curl: (3) <url> malformed
Failed to install helm-diff
\tFor support, go to https://github.com/databus23/helm-diff.
Error: plugin install hook for "diff" exited with error
The command '/bin/sh -c helm plugin install https://github.com/app-registry/appr-helm-plugin --version v${HELM_APPR_VERSION}     && helm plugin install https://github.com/mstrzele/helm-edit --version v${HELM_EDIT_VERSION}     && helm plugin install https://github.com/databus23/helm-diff --version v${HELM_DIFF_VERSION}     && helm plugin install https://github.com/futuresimple/helm-secrets --version ${HELM_SECRETS_VERSION}     && helm plugin install https://github.com/sagansystems/helm-github --version ${HELM_GITHUB_VERSION}' returned a non-zero code: 1

https://travis-ci.org/cloudposse/geodesic/builds/374046863?utm_source=github_status&utm_medium=notification

[databus23]

@osterman Not sure. If it works sometimes when re-running I think it could also be this #10 .

[kujenga]

I believe that I found a fix for this issue here: #51, I was running into this issue when trying to start using this plugin within CI as well.