Revert "Add auto-assign-on-comment.yaml (#14)" #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit de9bef9. Signed-off-by: Shingo OKAWA <[email protected]>
smurching
reviewed
Apr 28, 2025
Contributor
smurching
left a comment
smurching
left a comment
There was a problem hiding this comment.
Thanks @ognis1205 for the quick turnaround on this - for the other GitHub workflows, I had to configure them to run on specific self-hosted runners to get around the IP access list issue, e.g. see
mcp/.github/workflows/unit_tests.yml
Lines 15 to 17 in de9bef9
smurching
approved these changes
Apr 28, 2025
Contributor
Author
|
Thank you for the review and merge! Also, thank you for letting me know the workaround for this issue. I'll create another PR based on the settings you provided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit de9bef9.
Related Issues/PRs
Closes #15
What changes are proposed in this pull request?
This PR reverts the commit that introduced the auto-assign-on-comment workflow. This change was causing issues due to the IP restrictions in place for the databrickslabs organization, which blocked the workflow from functioning correctly.
How is this PR tested?
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
How should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes