-
Notifications
You must be signed in to change notification settings - Fork 227
Add support for values with self-closing tags #303
Conversation
Signed-off-by: Anton Alexandrov <[email protected]>
|
@BioQwer, I am sorry for the late response. It was LGTM. I manually resolved the conflict here. Few differences are I a little bit cleaned up and removed the change about allowing empty attribute prefixes. Maybe, we can do this in another PR. It's quite core change so it took me a while to double check. Mind taking another look before merging it in? |
|
BTW, let me try to prepare the release only after the current open PRs. It's been delayed again and again. |
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 88.46% 88.54% +0.07%
==========================================
Files 14 14
Lines 728 733 +5
Branches 99 93 -6
==========================================
+ Hits 644 649 +5
Misses 84 84
Continue to review full report at Codecov.
|
|
where can i find the last build, with this fixed? |
|
Hi - Thanks for the great work! What's the timeline for uploading the artifact for build |
|
Hi, I still do not see 0.4.2 on maven. Is there any ETA to it? |
|
It's currently blocked by #321 We should fix the tests before the release |
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... databricks#303
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... #303
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... databricks/spark-xml#303
Same for #285 but I resolved conflicts here. Should credit to him.
Closes #285
Closes #156
Closes #92
Closes #190
Closes #276