Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented May 13, 2018

Same for #285 but I resolved conflicts here. Should credit to him.

Closes #285
Closes #156
Closes #92
Closes #190
Closes #276

@HyukjinKwon
Copy link
Member Author

@BioQwer, I am sorry for the late response. It was LGTM. I manually resolved the conflict here. Few differences are I a little bit cleaned up and removed the change about allowing empty attribute prefixes. Maybe, we can do this in another PR.

It's quite core change so it took me a while to double check. Mind taking another look before merging it in?

@HyukjinKwon
Copy link
Member Author

BTW, let me try to prepare the release only after the current open PRs. It's been delayed again and again.

@codecov-io
Copy link

Codecov Report

Merging #303 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   88.46%   88.54%   +0.07%     
==========================================
  Files          14       14              
  Lines         728      733       +5     
  Branches       99       93       -6     
==========================================
+ Hits          644      649       +5     
  Misses         84       84
Impacted Files Coverage Δ
...cala/com/databricks/spark/xml/XmlInputFormat.scala 94.4% <100%> (+0.18%) ⬆️
...la/com/databricks/spark/xml/util/InferSchema.scala 87.14% <100%> (ø) ⬆️
...m/databricks/spark/xml/parsers/StaxXmlParser.scala 97.08% <100%> (ø) ⬆️
...abricks/spark/xml/parsers/StaxXmlParserUtils.scala 97.87% <100%> (+0.04%) ⬆️
...in/scala/com/databricks/spark/xml/XmlOptions.scala 97.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e29c5...382b75b. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 2dbcd38 into databricks:master May 16, 2018
@oshribr
Copy link

oshribr commented Jul 16, 2018

where can i find the last build, with this fixed?

@BioQwer
Copy link
Contributor

BioQwer commented Jul 17, 2018

@oshribr you can get here , build with this fixes.
it's my builds

@hunzinker
Copy link

Hi - Thanks for the great work! What's the timeline for uploading the artifact for build 0.4.2 to maven?

@ankit57
Copy link

ankit57 commented Sep 19, 2018

Hi, I still do not see 0.4.2 on maven. Is there any ETA to it?

@HyukjinKwon
Copy link
Member Author

It's currently blocked by #321

We should fix the tests before the release

cefn added a commit to cefn/spark-xml that referenced this pull request Jul 2, 2019
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... databricks#303
HyukjinKwon pushed a commit that referenced this pull request Jul 2, 2019
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... #303
FajarYulian52 added a commit to FajarYulian52/spark-xml that referenced this pull request Aug 4, 2024
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... databricks/spark-xml#303
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

6 participants