Output valid streaming XML with woodstox #282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 88.52% 88.44% -0.08%
==========================================
Files 14 14
Lines 732 727 -5
Branches 101 97 -4
==========================================
- Hits 648 643 -5
Misses 84 84
Continue to review full report at Codecov.
|
|
@HyukjinKwon let me know what you think. Thanks! |
|
Wow, thanks for fixing it @pwoody. Seems fine. Let me merge this one after another double check within few days. |
| var lastRow: Boolean = true | ||
|
|
||
| override def hasNext: Boolean = iter.hasNext || firstRow || lastRow | ||
|
|
There was a problem hiding this comment.
@pwoody, mind if I ask to remove val startElement = s"<${options.rootTag}>" and val endElement = s"</${options.rootTag}>" above? Seems unused.
pwoody
force-pushed
the
pw/multipleRootFix
branch
from
171df25 to
4d92847
Compare
Hadoop added a woodstox dependency in https://issues.apache.org/jira/browse/HADOOP-14501. When using versions of Hadoop with that dependency, WstxOutputFactory will get loaded for XMLOutputFactory.newInstance. The resulting streamwriter will ensure that a client does not write two root elements, which causes the current code to error out. This PR makes it such that the writer function will start the root tag before writing rows. Author: Patrick Woody <[email protected]> Closes #282 from pwoody/pw/multipleRootFix. (cherry picked from commit 3b09617) Signed-off-by: hyukjinkwon <[email protected]>
|
Merged to master and branch-0.4! |
|
Thanks @HyukjinKwon - what is the release cadence for a 0.4.x release? |
|
Will make a release soon within next week (after sorting out the current open PRs). Does that work for you too? |
|
Yep, no rush!
…Sent from my iPhone
On Apr 2, 2018, at 9:49 PM, Hyukjin Kwon ***@***.***> wrote:
Will make a release soon within next week (after sorting out the current open PRs). Does that work for you too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Hey, @pwoody. I'm really sorry that the release has been postponed. 0.5.0 is released now. Thank you for your work .. ! |
3 participants
Hadoop added a woodstox dependency in https://issues.apache.org/jira/browse/HADOOP-14501. When using versions of Hadoop with that dependency, WstxOutputFactory will get loaded for XMLOutputFactory.newInstance. The resulting streamwriter will ensure that a client does not write two root elements, which causes the current code to error out.
This PR makes it such that the writer function will start the root tag before writing rows.