Skip to content

ci: Refactor the whole ci into stages #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

ci: Refactor the whole ci into stages #3344

merged 1 commit into from
Dec 14, 2021

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Dec 10, 2021

Signed-off-by: Xuanwo [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Fix #3320

Changelog

  • Build/Testing/CI

@Xuanwo Xuanwo requested a review from BohuTANG as a code owner December 10, 2021 04:41
@databend-bot databend-bot added the pr-build this PR changes build/testing/ci steps label Dec 10, 2021
@databend-bot
Copy link
Member

databend-bot commented Dec 10, 2021

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

databend-bot commented Dec 10, 2021

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 10, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/BWeUVbgCbMnQgR4wXzAwfEvwnLaJ
✅ Preview: https://databend-git-fork-xuanwo-ci-databend.vercel.app

[Deployment for e264ce4 canceled]

@Xuanwo Xuanwo marked this pull request as draft December 10, 2021 04:42
@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @Xuanwo please rebase it 🙏

PsiACE
PsiACE reviewed Dec 10, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021 •
edited
Loading

Codecov Report

Merging #3344 (e264ce4) into main (09b1aa2) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3344   +/-   ##
=====================================
- Coverage     61%     61%   -1%     
=====================================
  Files        611     611           
  Lines      34194   34194           
=====================================
- Hits       20994   20993    -1     
- Misses     13200   13201    +1
Impacted Files Coverage Δ
...pelines/transforms/transform_aggregator_partial.rs 86% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09b1aa2...e264ce4. Read the comment docs.

@Xuanwo Xuanwo mentioned this pull request Dec 13, 2021
Merged
@Xuanwo Xuanwo marked this pull request as ready for review December 13, 2021 05:49
@BohuTANG
Copy link
Member

BohuTANG commented Dec 13, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

update

✅ Branch has been successfully updated

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 13, 2021 •
edited
Loading

This PR is not ready to be merged. We will need to remove the FIXME in production.yml after we make sure it works.

@BohuTANG
Copy link
Member

BohuTANG commented Dec 13, 2021

This PR is not ready to be merged. We will need to remove the FIXME in production.yml after we make sure it works.

Ok, I change it to draft to make it safe

@BohuTANG BohuTANG marked this pull request as draft December 13, 2021 06:33
@Xuanwo Xuanwo marked this pull request as ready for review December 13, 2021 08:40
@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 13, 2021

@BohuTANG I'm ready, let's rock!

@BohuTANG BohuTANG requested review from PsiACE and ZhiHanZ December 14, 2021 00:29
PsiACE
PsiACE approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks great, except for too many commits.

@databend-bot
Copy link
Member

databend-bot commented Dec 14, 2021

Wait for another reviewer approval

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 14, 2021

Let's squash it.

@databend-bot
Copy link
Member

databend-bot commented Dec 14, 2021

Wait for another reviewer approval

@Xuanwo
Refactor CI
e264ce4 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo mentioned this pull request Dec 14, 2021
Closed
3 tasks
@BohuTANG BohuTANG merged commit e190130 into databendlabs:main Dec 14, 2021
@Xuanwo Xuanwo deleted the ci branch December 14, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@ZhiHanZ ZhiHanZ Awaiting requested review from ZhiHanZ

1 more reviewer

@PsiACE PsiACE PsiACE approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-build this PR changes build/testing/ci steps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI speed improvement

6 participants

@Xuanwo @databend-bot @codecov-commenter @BohuTANG @ZhiHanZ @PsiACE