Skip to content

feat: add new string view type [part 1] #14662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2024
Merged

feat: add new string view type [part 1] #14662

merged 2 commits into from
Mar 1, 2024

Conversation

@ariesdevil
Copy link
Contributor

@ariesdevil ariesdevil commented Feb 16, 2024 •
edited by BohuTANG
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Impl the hyper style string.

This PR is based on Polars impls

This PR impls BinaryView and StringView for databend owned arrow.

Note: Currently, StringView is not actively used.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Feb 16, 2024
@ariesdevil ariesdevil force-pushed the string_view branch 8 times, most recently from 122c8ab to a807eb8 Compare February 22, 2024 13:44
@ariesdevil ariesdevil force-pushed the string_view branch 2 times, most recently from 7c1ae16 to 29f2e36 Compare February 26, 2024 13:09
@sundy-li sundy-li mentioned this pull request Feb 27, 2024
Closed
@ariesdevil ariesdevil force-pushed the string_view branch 2 times, most recently from 65b0286 to 748468a Compare February 27, 2024 11:27
@alamb alamb mentioned this pull request Feb 28, 2024
Closed
31 tasks
@ariesdevil ariesdevil force-pushed the string_view branch 4 times, most recently from 41435bf to 0dd76d5 Compare February 29, 2024 07:20
@ariesdevil ariesdevil marked this pull request as ready for review February 29, 2024 07:20
@sundy-li sundy-li requested review from Dousir9 and b41sh February 29, 2024 07:22
Dousir9
Dousir9 reviewed Mar 1, 2024
View reviewed changes
@BohuTANG BohuTANG added the ci-cloud Build docker image for cloud test label Mar 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Docker Image for PR

  • tag: pr-14662-0ca7d30

note: this image tag is only available for internal use,
please check the internal doc for more details.

@ariesdevil ariesdevil changed the title feat: add new string view type feat: add new string view type [part 1] Mar 1, 2024
@ariesdevil ariesdevil mentioned this pull request Mar 1, 2024
Closed
6 tasks
@BohuTANG BohuTANG merged commit a8ab8bc into databendlabs:main Mar 1, 2024
@ariesdevil ariesdevil deleted the string_view branch March 1, 2024 11:42
@ariesdevil ariesdevil mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundy-li sundy-li sundy-li approved these changes

@b41sh b41sh Awaiting requested review from b41sh

+1 more reviewer

@Dousir9 Dousir9 Dousir9 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ariesdevil @sundy-li @Dousir9 @BohuTANG