Add sections on Assumptions and signatures #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
reviewed
Aug 25, 2020
kgryte
reviewed
Aug 25, 2020
rgommers
commented
Sep 8, 2020
|
|
||
| Array libraries may know how to interoperate with each other, for example by | ||
| constructing their own array type from that of another library or by shared | ||
| memory use of an array (see [Data interchange mechanisms](design_topics/data_interchange.md)). |
Member
Author
There was a problem hiding this comment.
Everyone seemed happy with the assumptions in the call we discussed it in, 1.7 wks ago. The one comment on this data interchange was "can we just say now that this will be DLPack?". That should be in the section linked here, which is for another PR. So I'll go ahead and merge this as is.
This prevents repeating the same information multiple times; we can refer to this instead.
Includes: - hardware and software environments - dependencies (including abstract dependency diagram) - backwards compatibility - production code & interactive use
rgommers
force-pushed
the
assumptions
branch
from
e799384 to
28b1964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main topic of this PR is the assumptions section. This includes:
For the Python >=3.8 dependency I had to refer to the positional-only decision, so I factored out that content into a new section on function and method signatures (that shouldn't contain too much that's controversial).