BLD: use pyproject.toml not setup.py #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
approved these changes
Feb 3, 2025
Member
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
This all LGTM. All these dynamic versioning tools aren't great, but setuptools_scm is certainly an improvement over versioneer (most projects I know moved away from versioneer by now).
While at it, remove versioneer and use setuptools_scm for computing the version dynamically. This change is mainly because I did not manage to make versioneer work with pyproject.toml, while setuptools_scm "just worked" (well, nearly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While at it, remove
versioneerand usesetuptools_scmfor computing the version dynamically.This change is mainly because I did not manage to make
versioneerwork withpyproject.toml, while setuptools_scm "just worked" (well, nearly).Likely closes #89 (not sure what is the greyskull story in that issue though).