BUG: from_dlpack: fix default device
#108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I can confirm that this unblocks SciPy |
betatim
reviewed
Dec 11, 2024
betatim
reviewed
Dec 11, 2024
Member
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
One nitpick about is vs ==.
We could add an assert to check that the device of x is actually the default device?
We could add a non regression test that uses a numpy array as argument for from_dlpack?
Otherwise looks good to me
lucascolley
force-pushed
the
dlpack-device
branch
from
9297c32 to
f8a6a9e
Compare
Member
Author
|
thanks Tim, addressed |
betatim
approved these changes
Dec 11, 2024
Member
|
Thanks for the fix and the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gh-99