Enables the use of versions higher than 3.4.1 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the version of the library. Enables the use of versions higher than 3.4.1
… be ran and imported from files outside of the root folder. Added command line arguments for corenlp path & version string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parameter to the Stanford CoreNLP constructor called "version_str", which takes on the default value of "3.4.1".
This variable, when combined with with the "corenlp_path" variable, allows the usage of more recent versions of the coreNLP library without major refactoring of the code base. Simple pass the path of the library as well as the version string so that this python wrapper can successfully find and load the correct JAR files.
This change does not guarantee full compatibility with all versions and future releases of the Stanford CoreNLP Library - but has been used with up to the current latest version at this time (3.8.0) with no problems.