Skip to content

Fix clocks on Windows with Python 3.13 #8642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2024
Merged

Fix clocks on Windows with Python 3.13 #8642

merged 1 commit into from
May 8, 2024

Conversation

@vstinner
Copy link
Contributor

@vstinner vstinner commented May 7, 2024 •
edited
Loading

Closes #8641.

_WindowsTime is no longer needed on Windows with Python 3.13. On Windows, Python 3.13 now uses GetSystemTimePreciseAsFileTime() for time.time() and QueryPerformanceCounter() for time.monotonic().

  • Tests added / passed
  • Passes pre-commit run --all-files

@vstinner
Fix clocks on Windows with Python 3.13
f10c398 
Closes dask#8641.

_WindowsTime is no longer needed on Windows with Python 3.13. On
Windows, Python 3.13 now uses GetSystemTimePreciseAsFileTime() for
time.time() and QueryPerformanceCounter() for time.monotonic().

* python/cpython#116781
* python/cpython#116822
@vstinner vstinner requested a review from fjetter as a code owner May 7, 2024 17:22
@GPUtester
Copy link
Collaborator

GPUtester commented May 7, 2024

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

This was referenced May 7, 2024
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   10h 57m 17s ⏱️ - 2m 19s
 4 051 tests ±0   3 950 ✅  - 1     97 💤 ±0  4 ❌ +1 
55 799 runs  ±0  53 634 ✅ ±0  2 160 💤 ±0  5 ❌ ±0 

For more details on these failures, see this check.

Results for commit f10c398. ± Comparison against base commit d5edb4e.

fjetter
fjetter approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this and congrats for your first dask contribution!

@fjetter fjetter merged commit e4a0545 into dask:main May 8, 2024
@vstinner vstinner deleted the py313 branch May 8, 2024 10:39
@vstinner
Copy link
Contributor Author

vstinner commented May 8, 2024

Thank you for fixing this and congrats for your first dask contribution!

You're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjetter fjetter fjetter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

distributed hangs on Windows with Python 3.13

3 participants

@vstinner @GPUtester @fjetter