Don't cleanup datadir #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
approved these changes
Apr 23, 2019
grouma
added a commit
that referenced
this pull request
Apr 26, 2019
- As suggested by the Chrome docs, always use a tmp dir when passing `--remote-debugging-port` - Add graceful exit handler for daemon command - This ensures that Chrome is properly closed - Temporary pin build_daemon version to fix integration tests - Fix concurrent modification issue Closes #319 Closes #300 This reverts #322 & #316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use a system temp dir. This is intended to be kept around preserving user settings.