Skip to content

Remove unused path are to PubspecLock.read #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Remove unused path are to PubspecLock.read #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions webdev/lib/src/command/shared.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@ List<String> buildRunnerArgs(
return arguments;
}

Future<PubspecLock> readPubspecLock(Configuration configuration,
[String path]) async {
var pubspecLock = await PubspecLock.read(path);
Future<PubspecLock> readPubspecLock(Configuration configuration) async {
var pubspecLock = await PubspecLock.read();
await checkPubspecLock(pubspecLock,
requireBuildWebCompilers: configuration.requireBuildWebCompilers);
return pubspecLock;
Expand Down
6 changes: 3 additions & 3 deletions webdev/lib/src/pubspec.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ class PubspecLock {

PubspecLock(this._packages);

static Future<PubspecLock> read([String path]) async {
path ??= 'pubspec.lock';
static Future<PubspecLock> read() async {
await _runPubDeps();

var pubspecLock = loadYaml(await File(path).readAsString()) as YamlMap;
var pubspecLock =
loadYaml(await File('pubspec.lock').readAsString()) as YamlMap;

var packages = pubspecLock['packages'] as YamlMap;
return PubspecLock(packages);
Expand Down