Skip to content

handle failures to set up the debug service #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2019
Merged

handle failures to set up the debug service #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions webdev/lib/src/serve/handlers/dev_handler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,20 @@ class DevHandler {
return;
}

var appServices =
await loadAppServices(message.appId, message.instanceId);
AppDebugServices appServices;
try {
appServices =
await loadAppServices(message.appId, message.instanceId);
} catch (_) {
connection.sink.add(
jsonEncode(webdev.serializers.serialize(DevToolsResponse((b) => b
..success = false
..error = 'Webdev was unable to connect debug services to your '
'application. Most likely this means you are trying to '
'load in a different Chrome window than was launched by '
'webdev.'))));
return;
}

// Check if we are already running debug services for a different
// instance of this app.
Expand Down