updates to the daemon.log event #307
Conversation
| setLogHandler((level, message, {verbose}) { | ||
| daemonDomain | ||
| .sendEvent('daemon.log', {'level': '$level', 'message': message}); | ||
| if (verbose == true) { |
There was a problem hiding this comment.
This seems a bit odd to be based on the --verbose flag, what is the context?
There was a problem hiding this comment.
Are you sure this is what we want to do?
I feel like these messages should always be displayed as they provide build action updates, e.g.:
[INFO] Generating build script completed, took 375ms
[INFO] Setting up file watchers completed, took 13ms
[INFO] Waiting for all file watchers to be ready completed, took 116ms
[INFO] Reading cached asset graph completed, took 333ms
[INFO] Checking for updates since last build completed, took 831ms
[INFO] Running build completed, took 331ms
[INFO] Caching finalized dependency graph completed, took 195ms
[INFO] Succeeded after 534ms with 0 outputs (0 actions)
There was a problem hiding this comment.
Yeah, it definitely depends on the types of messages that it's sending w/ verbose==true. If these should be user facing in general, then we'd want to send them all to daemon.log.
One way to think about it is, would these messages show as part of the output for a normal flutter run from the cli? Or, would they only show w/ a flutter run -v run?
There was a problem hiding this comment.
I updated this to send all messages from here through 'daemon.log'.
There was a problem hiding this comment.
Yeah these should all be displayed. Sorry I forgot to change the structure of the message. Thanks for the PR.
@grouma