Shutdown the daemon when the application is closed #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Apr 16, 2019
| var chrome = await Chrome.connectedInstance; | ||
| await chrome.close(); | ||
| await _appDebugServices.debugService.chromeProxyService.tabConnection | ||
| .close(); |
There was a problem hiding this comment.
Just to clarify, does this only close the application tab?
There was a problem hiding this comment.
also what happens if the tab is already closed?
There was a problem hiding this comment.
This only closes the tab. In the case that we launch Chrome the resulting chrome process will be killed. The tab can't already be closed because closing the tab results in the daemon shutting down.
jakemac53
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #271