Skip to content

Update pattern test to account for new DDC JS variable naming #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Update pattern test to account for new DDC JS variable naming #2542

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3a263c
Update pattern test to account for new DDC JS variable naming
biggs0125 Dec 13, 2024
3212357
Dart format
biggs0125 Dec 13, 2024
4d8acf0
Dart format 2
natebiggs Dec 13, 2024
2849c65
Add version guard around condition.
natebiggs Dec 13, 2024
e266157
Dart format
natebiggs Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions dwds/test/instances/common/patterns_inspection_common.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import 'package:test/test.dart';
import 'package:test_common/logging.dart';
import 'package:test_common/test_sdk_configuration.dart';
import 'package:test_common/utilities.dart';
import 'package:vm_service/vm_service.dart';

import '../../fixtures/context.dart';
Expand Down Expand Up @@ -96,11 +97,24 @@ void runTests({
await onBreakPoint('testPatternCase2', (event) async {
final frame = event.topFrame!;

expect(await getFrameVariables(frame), {
'obj': matchListInstance(type: 'Object'),
'a': matchPrimitiveInstance(kind: InstanceKind.kString, value: 'b'),
'n': matchPrimitiveInstance(kind: InstanceKind.kDouble, value: 3.14),
});
if (dartSdkIsAtLeast('3.7.0-246.0.dev')) {
expect(await getFrameVariables(frame), {
'obj': matchListInstance(type: 'Object'),
// Renamed to avoid shadowing variables from previous case.
'a\$':
matchPrimitiveInstance(kind: InstanceKind.kString, value: 'b'),
'n\$':
matchPrimitiveInstance(kind: InstanceKind.kDouble, value: 3.14),
});
} else {
expect(await getFrameVariables(frame), {
'obj': matchListInstance(type: 'Object'),
// Renamed to avoid shadowing variables from previous case.
'a': matchPrimitiveInstance(kind: InstanceKind.kString, value: 'b'),
'n':
matchPrimitiveInstance(kind: InstanceKind.kDouble, value: 3.14),
});
}
});
});

Expand Down
Loading