Updating test expectations for DDC Set implementations. #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
approved these changes
Jul 4, 2024
Contributor
|
Note that this PR introduced a new CI failure (during analysis, as there is now an unused variable). |
Contributor
|
In general, when merging on red we should provide an explanation, and if there is a known failure then an issue should be filed to resolve it, or possibly skip the test etc, so that new failures like this aren't missed. |
Collaborator
That's my bad, I somehow missed that there was a failure and hit merge... I'll fix this now. |
Merged
bkonyi
added a commit
that referenced
this pull request
Jul 9, 2024
* Remove unused variable Follow up to #2458 * Fix additional test failure * Fix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDC Sets Impls are now in
dart:_js_helper(like with Maps) instead ofdart:collection.