Skip to content

Conversation

@elliette
Copy link
Contributor

@elliette elliette commented Apr 16, 2024

This is equivalent to what Devtools did a while back: flutter/devtools#6703

It ensures that we don't get new DCM failures on PRs when DCM is updated

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Apr 16, 2024
@elliette elliette requested review from Markzipan and nshahan April 16, 2024 21:51
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG, this is the first I've heard of DCM. I'd be curious to hear more from you about how it helps out development for this repo.

@elliette elliette merged commit 16dce1f into dart-lang:master Apr 18, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 22, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/d23112a..aa139fd):
  aa139fd  2024-04-18  William Hesse  Add support for running perftools to use hardware performance counters when benchmarking. (dart-archive/benchmark_harness#98)

dartdoc (https://github.com/dart-lang/dartdoc/compare/592694e..1ae5b4c):
  1ae5b4c0  2024-04-22  dependabot[bot]  Bump actions/upload-artifact from 4.3.1 to 4.3.3 (dart-lang/dartdoc#3755)
  5934d2d6  2024-04-22  dependabot[bot]  Bump actions/checkout from 4.1.2 to 4.1.3 (dart-lang/dartdoc#3754)
  a9500f0d  2024-04-22  Sam Rawlins  Replace hasPrivateName/hasPublicName with one extension getter (dart-lang/dartdoc#3752)

tools (https://github.com/dart-lang/tools/compare/d86ea23..3e21ae9):
  3e21ae9  2024-04-22  Elias Yishak  `Event` Constructor added for devtools event (dart-lang/tools#258)

webdev (https://github.com/dart-lang/webdev/compare/3a10b76..d4f9f67):
  d4f9f672  2024-04-22  Devon Carew  remove the dep on package:uuid (dart-lang/webdev#2415)
  78555cdd  2024-04-18  Kevin Moore  FE server common: move from pkg:usage to pkg:uuid (dart-lang/webdev#2412)
  16dce1f2  2024-04-18  Elliott Brooks  Pin DCM to latest version (dart-lang/webdev#2410)
  b0494fb5  2024-04-18  Elliott Brooks  Catch errors when calculating frames in the stack trace (dart-lang/webdev#2408)

Change-Id: I1d206665e33e5936f4a5bf93e029a7290803895d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364021
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants