Renaming "legacy" paths and DDC modules to "DDC" paths and modules. #2360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for working on this large renaming/standardization effort across the board @Markzipan! Will make everything much easier to follow and understand =] |
elliette
reviewed
Jan 31, 2024
Contributor
elliette
left a comment
elliette
left a comment
There was a problem hiding this comment.
Changes LGTM but looks like the tests need to updated as well!
Contributor
Author
|
Thanks for reviewing! I missed |
elliette
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns our naming scheme for the DDC module system.
See related change in the SDK: https://dart-review.googlesource.com/c/sdk/+/348183
This is part of a greater effort to deprecate the AMD module system: dart-lang/sdk#52361