Add initial DDS support #1092
Merged
Add initial DDS support #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a service extension, `_yieldControlToDDS`, which always returns `Success`. This extension should place DWDS in single client mode so VM service clients are required to connect through DDS. See #1091
Member
Collaborator
Author
Thanks for pointing out where this should be implemented. I've updated the PR with a single client mode implementation. |
grouma
approved these changes
Sep 1, 2020
Member
grouma
left a comment
grouma
left a comment
There was a problem hiding this comment.
Let's get a changelog entry. Otherwise LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a service extension,
_yieldControlToDDS, which always returnsSuccess. This extension should place DWDS in single client mode so VMservice clients are required to connect through DDS.
See #1091