Skip to content

[web_generator] Bug Fixes in Entrypoint gen_interop_bindings.dart #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

[web_generator] Bug Fixes in Entrypoint gen_interop_bindings.dart #423

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de1b7b1
[web_generator] removed duplicate help option
nikeokoronkwo Jul 20, 2025
37a8c5d
Added support for no config passing in entrypoint
nikeokoronkwo Jul 20, 2025
c5dbe18
fix analyze and format issues
nikeokoronkwo Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions web_generator/bin/gen_interop_bindings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,11 @@ $_usage''');
final inputFile = argResult.rest.first;
final outputFile = argResult['output'] as String? ??
p.join(p.current, inputFile.replaceAll('.d.ts', '.dart'));
final configFile =
argResult['config'] as String? ?? p.join(p.current, 'webgen.yaml');
final defaultWebGenConfigPath = p.join(p.current, 'webgen.yaml');
final configFile = argResult['config'] as String? ??
(File(defaultWebGenConfigPath).existsSync()
? defaultWebGenConfigPath
: null);
final relativeOutputPath =
p.relative(outputFile, from: bindingsGeneratorPath);
// Run app with `node`.
Expand All @@ -73,7 +76,7 @@ $_usage''');
'--declaration',
'--input=${p.relative(inputFile, from: bindingsGeneratorPath)}',
'--output=$relativeOutputPath',
'--config=$configFile'
if (configFile case final config?) '--config=$config'
],
workingDirectory: bindingsGeneratorPath,
);
Expand All @@ -100,5 +103,5 @@ final _parser = ArgParser()
..addOption('config',
hide: true,
abbr: 'c',
help: 'The configuration file to use for this tool (NOTE: Unimplemented)')
..addFlag('help', negatable: false);
help:
'The configuration file to use for this tool (NOTE: Unimplemented)');