- 
                Notifications
    You must be signed in to change notification settings 
- Fork 76
Remove test skip on Windows. #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Package publishing
 Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. | 
| PR HealthBreaking changes ✔️
 This check can be disabled by tagging the PR with  Changelog Entry ✔️
 Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with  
Coverage  | 
| File | Coverage | 
|---|---|
| pkgs/watcher/lib/src/directory_watcher/windows.dart | 💔 0 % ⬇️ NaN % | 
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources | 
|---|
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files | 
|---|
| no missing headers | 
All source files should start with a license header.
Unrelated files missing license headers
| Files | 
|---|
| pkgs/bazel_worker/benchmark/benchmark.dart | 
| pkgs/bazel_worker/example/client.dart | 
| pkgs/bazel_worker/example/worker.dart | 
| pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart | 
| pkgs/boolean_selector/example/example.dart | 
| pkgs/clock/lib/clock.dart | 
| pkgs/clock/lib/src/clock.dart | 
| pkgs/clock/lib/src/default.dart | 
| pkgs/clock/lib/src/stopwatch.dart | 
| pkgs/clock/lib/src/utils.dart | 
| pkgs/clock/test/clock_test.dart | 
| pkgs/clock/test/default_test.dart | 
| pkgs/clock/test/stopwatch_test.dart | 
| pkgs/clock/test/utils.dart | 
| pkgs/coverage/lib/src/coverage_options.dart | 
| pkgs/html/example/main.dart | 
| pkgs/html/lib/dom.dart | 
| pkgs/html/lib/dom_parsing.dart | 
| pkgs/html/lib/html_escape.dart | 
| pkgs/html/lib/parser.dart | 
| pkgs/html/lib/src/constants.dart | 
| pkgs/html/lib/src/encoding_parser.dart | 
| pkgs/html/lib/src/html_input_stream.dart | 
| pkgs/html/lib/src/list_proxy.dart | 
| pkgs/html/lib/src/query_selector.dart | 
| pkgs/html/lib/src/token.dart | 
| pkgs/html/lib/src/tokenizer.dart | 
| pkgs/html/lib/src/treebuilder.dart | 
| pkgs/html/lib/src/utils.dart | 
| pkgs/html/test/dom_test.dart | 
| pkgs/html/test/parser_feature_test.dart | 
| pkgs/html/test/parser_test.dart | 
| pkgs/html/test/query_selector_test.dart | 
| pkgs/html/test/selectors/level1_baseline_test.dart | 
| pkgs/html/test/selectors/level1_lib.dart | 
| pkgs/html/test/selectors/selectors.dart | 
| pkgs/html/test/support.dart | 
| pkgs/html/test/tokenizer_test.dart | 
| pkgs/html/test/trie_test.dart | 
| pkgs/html/tool/generate_trie.dart | 
| pkgs/pubspec_parse/test/git_uri_test.dart | 
| pkgs/stack_trace/example/example.dart | 
| pkgs/watcher/test/custom_watcher_factory_test.dart | 
| pkgs/yaml_edit/example/example.dart | 
This check can be disabled by tagging the PR with skip-license-check.
1876359    to
    37bc8bf      
    Compare
  
    37bc8bf    to
    1260b09      
    Compare
  
    | Superseded by #2204 | 
Fix #1701
The test was skipped because the expectations did not match, and the expectations did not match because there were extra incorrect "modify" events being reported.
_sortEventswas documented as "...won't return anyFileSystemMoveEvents", but actually it did returnFileSystemMoveEvents. Fix the implementation to do what the comment says, and that also fixes the bug :) ... what was happening was that move caused_canonicalEventto returnnull, then the filesystem would be checked and because before+after both had something at that path, a "modify" was reported.