Remove executable argument forwarding in tests #2533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to #2528 This case of argument forwarding existed since the test runner was first written. It's not clear exactly why it was necessary, so removing it if no current tests break.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
devoncarew
approved these changes
Aug 27, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 8, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. test (https://github.com/dart-lang/test/compare/5aef971..b99d556): b99d556 2025-09-01 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/test#2534) abe4939b 2025-08-27 Nate Bosch Remove executable argument forwarding in tests (dart-lang/test#2533) 81e0579c 2025-08-26 Ömer Sinan Ağacan Serve dart2wasm source map files (dart-lang/test#2532) 9354f239 2025-08-07 Liam Appelbe Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517) Change-Id: I7297cc534d03de343218c829a8e94d70ba35a023 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448423 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 10, 2025
This reverts commit caece5d. Reason for revert: broke Flutter build (dart-lang/test#2517 (comment)) Original change's description: > [deps] rev test > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > test (https://github.com/dart-lang/test/compare/5aef971..b99d556): > b99d556 2025-09-01 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/test#2534) > abe4939b 2025-08-27 Nate Bosch Remove executable argument forwarding in tests (dart-lang/test#2533) > 81e0579c 2025-08-26 Ömer Sinan Ağacan Serve dart2wasm source map files (dart-lang/test#2532) > 9354f239 2025-08-07 Liam Appelbe Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517) > > Change-Id: I7297cc534d03de343218c829a8e94d70ba35a023 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448423 > Auto-Submit: Devon Carew <[email protected]> > Reviewed-by: Konstantin Shcheglov <[email protected]> > Commit-Queue: Konstantin Shcheglov <[email protected]> Change-Id: I5404155f0de9330d37ff74741dd64a1a8d0436d2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448906 Reviewed-by: Alexander Aprelev <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2528
This case of argument forwarding existed since the test runner was first
written. It's not clear exactly why it was necessary, and it should be safe
to remove.
The existing argument forwarding breaks some tests on CI where an
unexpected argument is passed to some dart invocations.