[native assets] Graduate to preview #2501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
Contributor
Author
|
FYI @mosuem It looks like this publish lint violation is intentional. |
mkustermann
approved these changes
May 21, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 21, 2025
This PR enables native assets on the main and dev channel by default, and make native assets available on the beta channel. This PR removes the flag from invocations. The helper packages (`package:hooks` and `package:code_assets`) will stay 0.x for now, until the SDK constraint can be bumped to a beta release and we're happy with the Dart API. `dart build` is also made available as preview (without a flag on the main, dev, and beta channels). We're still finalizing the spec for this command. (#60730) `dart test` will need dart-lang/test#2501. This means users will need to update their `package:test` dependency. This PR refactors the way that invalid `package_config.json`s are handled: they are now loaded in the dartdev commands and handled there. Bug: #50565 Project: https://github.com/orgs/dart-lang/projects/99/ Change-Id: I7db9ff6d7196750cab9379a4605c6bbf89a974d7 Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-win-release-arm64-try,pkg-mac-release-try,pkg-win-release-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429920 Commit-Queue: Daco Harkes <[email protected]> Reviewed-by: Martin Kustermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experiment flag will be on by default so it is not passed as argument anymore.
Accompanying Dart CL: https://dart-review.googlesource.com/c/sdk/+/429920