Skip to content

Conversation

@koji-1009
Copy link

Fix firefox startup path, as dart test -p firefox can no longer be executed on macOS.

close #2194

I checked the workflow and both macos and firefox are removed from the execution environment. In relation to PR, do I need to add macos and firefox execution patterns to the workflow?


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@jakemac53 jakemac53 requested a review from natebosch March 5, 2024 19:06
@jakemac53
Copy link
Contributor

Ah crap, I realize now that this doesn't work for the executables which aren't actually a file path, but instead are an executable name expected to be on your PATH.

Not sure the best way to deal with those, cc @natebosch ideas?

@natebosch
Copy link
Member

I don't recall a way to check for an executable on the $PATH in Dart.

If macOS is the only one which needs multiple options today, should we only update the mac behavior to support multiple full paths?

@koji-1009
Copy link
Author

We can do a workaround in dart_test.yaml, so why not change the default to firefox and have firefox-bin set in an environment that supports the old Firefox?
As Firefox browsers are updated, the importance of firefox-bin seems to gradually decrease.

We are able to do a workaround by setting the following yaml.

override_platforms:
  firefox:
    settings:
      executable: 
        mac_os: '/Applications/Firefox.app/Contents/MacOS/firefox-bin'

@koji-1009 koji-1009 closed this Oct 1, 2024
@koji-1009 koji-1009 deleted the fix/firefox_macos branch October 1, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firefox fails to start when called via /Applications/Firefox.app/Contents/MacOS/firefox-bin on macOS

3 participants