Only use environment variable for chrome #1970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new argument to the `ExectuableSettings` constructor to add an environment variable that can override the specific executable, instead of overriding for all uses of `ExectuableSettings`. Pass this variable from the chrome browser. Add a test that the override is ignored when running a firefox test.
jakemac53
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new argument to the
ExectuableSettingsconstructor to add anenvironment variable that can override the specific executable, instead
of overriding for all uses of
ExectuableSettings. Pass this variablefrom the chrome browser.
Add a test that the override is ignored when running a firefox test.